Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MUI Toolpad to Toolpad Studio #3238

Merged
merged 45 commits into from
Mar 9, 2024
Merged

Rename MUI Toolpad to Toolpad Studio #3238

merged 45 commits into from
Mar 9, 2024

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Feb 23, 2024 •
edited by oliviertassinari
Loading

Rename MUI Toolpad to Toolpad Studio.
Does not introduce breaking changes - create-toolpad-app creates an app using the renamed packages.

@apedroferreira apedroferreira self-assigned this Feb 23, 2024
@apedroferreira apedroferreira added core Infrastructure work going on behind the scenes breaking change labels Feb 23, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 25, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 28, 2024
apedroferreira
apedroferreira commented Feb 28, 2024
View reviewed changes
packages/create-toolpad-app/tests/index.spec.ts Outdated
@@ -35,8 +35,9 @@ async function waitForMatch(input: Readable, regex: RegExp): Promise<RegExpExecA
});
}

test(
'create-toolpad-app can bootstrap a Toolpad app',
// @TODO: Unskip once @mui/toolpad-studio is released for the first time.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can unskip this after we publish, the test fails because @mui/toolpad-studio hasn't been published yet.

@apedroferreira apedroferreira marked this pull request as ready for review February 28, 2024 16:39
@apedroferreira
Copy link
Member Author

This should be it? Hopefully I didn't miss anything important as it's a lot of changes...

I didn't update much on the docs as they're being worked on separately, we can sync them afterwards if it's needed.

@apedroferreira apedroferreira requested a review from a team February 28, 2024 16:40
@apedroferreira apedroferreira changed the title Rename Toolpad to Studio Rename Toolpad to Toolpad Studio Feb 28, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 1, 2024
@apedroferreira
Copy link
Member Author

apedroferreira commented Mar 8, 2024 •
edited
Loading

Not sure what Vale is complaining about, the results are kind of hard to read, I guess I can try to add all the fixes it mentions.... Other than that this PR should be ready.
I guess I figured it out, but it was reporting errors for things I didn't change.

@apedroferreira apedroferreira removed request for a team and Janpot March 8, 2024 18:10
@Janpot
Copy link
Member

Janpot commented Mar 8, 2024

you can ignore vale errors for this PR as far as I'm concerned. @bharatkashyap

@apedroferreira
Copy link
Member Author

you can ignore vale errors for this PR as far as I'm concerned. @bharatkashyap

It's ok i fixed them all, but yeah it was a bit much and too strict, there's a limit of 10 warnings too...
Once this PR is all green we can merge if it looks good, I'll handle the flaky test separately next.

@apedroferreira
Copy link
Member Author

you can ignore vale errors for this PR as far as I'm concerned. @bharatkashyap

It's ok i fixed them all, but yeah it was a bit much and too strict, there's a limit of 10 warnings too... Once this PR is all green we can merge if it looks good, I'll handle the flaky test separately next.

I can't get that flaky test to pass, but it's unrelated to this PR... I'll work on fixing it next asap, feel free to review this so we can merge before there are more conflicts.

@apedroferreira apedroferreira requested review from Janpot, a team and bharatkashyap and removed request for a team March 8, 2024 19:19
Janpot
Janpot approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes let's keep this pr about renaming and fix preexisting issues separately

@bharatkashyap bharatkashyap merged commit eeefa34 into mui:master Mar 9, 2024
10 of 12 checks passed
@apedroferreira apedroferreira deleted the studio-rename branch March 11, 2024 20:05
@oliviertassinari
Copy link
Member

Exciting change ahead!

@oliviertassinari oliviertassinari changed the title Rename Toolpad to Toolpad Studio Rename MUI Toolpad to Toolpad Studio Mar 11, 2024
@oliviertassinari
Copy link
Member

The examples were all failing

SCR-20240317-pqci

Fixed in 9003b91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

@bharatkashyap bharatkashyap Awaiting requested review from bharatkashyap

Assignees

@apedroferreira apedroferreira

Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apedroferreira @Janpot @oliviertassinari @bharatkashyap