Fix unintentional page rows being created #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must have been caused a while ago in #2635 but I hadn't noticed until now, or maybe it only made itself visible now due to the recent fixes:
When dragging elements just outside a page row, new page rows with page rows inside were being created and it could get quite messy. This PR adjusts the logic and seems to be a good fix from what I've tested.
Added a visual test to cover this bug.
Before:
Screen.Recording.2024-02-16.at.00.32.16.mov
After:
Screen.Recording.2024-02-16.at.00.32.56.mov