Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the inline canvas uses the correct font #3208

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 13, 2024

No description provided.

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Feb 13, 2024
@Janpot Janpot marked this pull request as ready for review February 13, 2024 12:48
@Janpot Janpot requested a review from a team February 13, 2024 13:51
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, not sure if there is any way of optimising this for performance

@Janpot
Copy link
Member Author

Janpot commented Feb 14, 2024

It's quite fast compared to the current system, have you tried it? Pages open instantly in the editor now. I guess at some point we can think about removing the iframe altogether, but let's remove the legacy first.

@Janpot Janpot merged commit d2a07fb into mui:master Feb 14, 2024
10 of 11 checks passed
@Janpot Janpot deleted the fix-canvas-font branch February 14, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants