Authentication fixes/improvements #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
Janpot
reviewed
Feb 7, 2024
| @@ -1627,7 +1627,12 @@ export default function ToolpadApp({ rootRef, basename, state }: ToolpadAppProps | |||
| (window as any).toggleDevtools = () => toggleDevtools(); | |||
| }, [toggleDevtools]); | |||
|
|
|||
| const authContext = useAuth({ dom, basename, isRenderedInCanvas: IS_RENDERED_IN_CANVAS }); | |||
| const authContext = useAuth({ | |||
There was a problem hiding this comment.
No need to pass this around anymore, can get it from context, see #3170
github-actions
bot
removed
the
PR: out-of-date
Janpot
approved these changes
Feb 7, 2024
Janpot
reviewed
Feb 7, 2024
| @@ -13,6 +13,8 @@ import { asyncHandler } from '../utils/express'; | |||
| import { adaptRequestFromExpressToFetch } from './httpApiAdapters'; | |||
| import type { ToolpadProject } from './localMode'; | |||
|
|
|||
| globalThis.crypto ??= (await import('node:crypto')) as Crypto; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, I've added a comment too explaining why we have the polyfill 62ac5f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cryptofor Node 18 usersCloses #3172