Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Avoid aliasing to the monorepo dependencies #3137

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 26, 2024

Avoid using @mui-internal/babel-macros
Bring it closer to the MUI X implementation

@Janpot Janpot added the docs Improvements or additions to the documentation label Jan 26, 2024
@Janpot Janpot changed the title Avoid aliasing to the monorepo dependencies [code-infra] Avoid aliasing to the monorepo dependencies Jan 26, 2024
@Janpot Janpot marked this pull request as ready for review January 27, 2024 05:45
@Janpot Janpot requested a review from a team January 27, 2024 05:46
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2024
@@ -27,6 +27,7 @@
"@emotion/server": "11.11.0",
"@emotion/styled": "11.11.0",
"@mui/icons-material": "5.15.6",
"@mui/joy": "5.0.0-beta.24",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for any of the changes in this PR? Or was it missing before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed to be missing before

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 1, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Feb 1, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 1, 2024
@Janpot Janpot enabled auto-merge (squash) February 1, 2024 12:21
@Janpot Janpot merged commit 290c0d4 into mui:master Feb 1, 2024
11 checks passed
@Janpot Janpot deleted the avoid-monorepo-alias branch February 1, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants