Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication examples #3135

Merged
merged 17 commits into from
Feb 14, 2024
Merged

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Jan 26, 2024

Add examples of authentication for Github and Google, but without the needed environment variables which would need to be added by the person who tries the example.
The examples have .env.example files that show what environment variables can be set, plus the READMEs link to the relevant documentation.

@apedroferreira apedroferreira added the docs Improvements or additions to the documentation label Jan 26, 2024
@apedroferreira apedroferreira self-assigned this Jan 26, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 26, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 31, 2024
@apedroferreira apedroferreira marked this pull request as ready for review February 9, 2024 01:26
@apedroferreira apedroferreira requested a review from a team February 9, 2024 01:26
examples/auth/README.md Outdated Show resolved Hide resolved
@@ -62,7 +62,7 @@ If your application has dependencies other than `@mui/toolpad`, you have to temp
1. Make sure to start the build in watch mode again and the run the app with

```bash
pnpm toolpad dev examples/qr-generator --dev
pnpm toolpad dev examples/qr-generator/toolpad --dev
Copy link
Member Author

@apedroferreira apedroferreira Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't include /toolpad it creates the files outside the toolpad folder, that's not expected, right? Or am I doing something wrong?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this get resolved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well after this change and it matches the command that was already in step 3 above it, so I'm pretty sure this should be the way to write it.

@apedroferreira apedroferreira changed the title Add authentication example Add authentication examples Feb 13, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@apedroferreira apedroferreira merged commit f0b858d into mui:master Feb 14, 2024
11 checks passed
@apedroferreira apedroferreira deleted the auth-example branch February 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants