Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve portability of ToolpadApp #3126

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Improve portability of ToolpadApp #3126

merged 8 commits into from
Jan 25, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 25, 2024 •
edited
Loading

Batch of changes extracted from #3125

  • Remove reliance on variables defined by the bundler. Use a context instead.
  • In binding engine, make sure there is always an iframe
  • Remove import.meta.url shims
  • Resolve platform incompatibilities with URL constructor in Next.js runtime
  • Remove outdated cjs exports

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jan 25, 2024
@Janpot Janpot marked this pull request as ready for review January 25, 2024 11:05
@Janpot Janpot requested a review from a team January 25, 2024 11:05
@Janpot Janpot changed the title Improve portability of Toolpad app code Improve portability of ToolpadApp Jan 25, 2024
@Janpot Janpot merged commit 0831f50 into mui:master Jan 25, 2024
11 checks passed
@Janpot Janpot deleted the extract-next-stuff branch January 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @apedroferreira