Make Toolpad apps compatible with pnpm #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Potoms <[email protected]>
Janpot
changed the title
Janpot
changed the title
apedroferreira
approved these changes
Jan 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2244
Turns out that our pnpm migration is blocked on this. After migrating, it became impossible to run the examples. This PR switches the root dir of the toolpad application to the module itself. That way all module resolution happens from the correct folder. User modules like components are reselved with an alias. I've added a mechanism to fallback module imports of
@mui/materialin custom components to the toolpad nested one. This allows users to create custom components with errors if they didn't install@mui/materialfirst.