Improve authorization middleware #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
commented
Jan 12, 2024
| if ( | ||
| (!project.options.dev || isPageRequest) && |
There was a problem hiding this comment.
In dev mode it only redirects pages so that the user in preview sees the same behavior there will be in production. Can't hide RPC requests behind authentication in dev mode for example, as the editor needs to make them.
Janpot
approved these changes
Jan 15, 2024
|
Looks good. Annoying that we have a parallel dev and prod implementation. A more ideal implementation would be one single function which switches on/off certain middleware based on a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve authorization middleware to cover everything under
/prodexcept static files and Toolpad dev server.This way, the same middleware can be used to redirect to sign in and protect the RPC, among other things.