Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list, datepicker and textfield component guides #2827

Merged
merged 50 commits into from
Mar 4, 2024

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Oct 24, 2023

List: https://deploy-preview-2827--mui-toolpad-docs.netlify.app/toolpad/components/list/
DatePicker: https://deploy-preview-2827--mui-toolpad-docs.netlify.app/toolpad/components/date-picker/
TextField: https://deploy-preview-2827--mui-toolpad-docs.netlify.app/toolpad/components/text-field/

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 24, 2023
@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Oct 24, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in the reference docs we used a hyphen to split words in the file name, date-picker. Can you verify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the file names are data-grid, date-picker, and file-picker. Ok, so I'll follow the same here.

@Janpot
Copy link
Member

Janpot commented Feb 27, 2024

I pushed a fix, to allow the datePicker to be rendered in a SSR context

prakhargupta1 and others added 2 commits February 27, 2024 15:21
Co-authored-by: Jan Potoms <[email protected]>
Signed-off-by: Prakhar Gupta <[email protected]>
@prakhargupta1
Copy link
Member Author

Date picker, text field still break:

Screen.Recording.2024-02-27.at.3.37.49.PM.mov

@Janpot
Copy link
Member

Janpot commented Feb 27, 2024

Date picker, text field still break:

fix added. Also fixed the format in the format demo (had to be uppercase)

@prakhargupta1
Copy link
Member Author

About the missing demo in the list component, I guess we can't add it. So I should just remove it?

@Janpot
Copy link
Member

Janpot commented Feb 27, 2024

About the missing demo in the list component, I guess we can't add it. So I should just remove it?

I don't know what it would look like. @bharatkashyap if you have an idea, otherwise we can omit.

  • Can you add links to the PR preview
  • Can you address the vale comments

@apedroferreira
Copy link
Member

apedroferreira commented Feb 27, 2024

Should we remove the isInvalid prop from all components for now as discussed in #2826? I can remove it if we agree.

I'll create an issue about finding a better solution for that sort of thing.

Edit: done and merged #3260, and issue here #3261

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge, I'll add this in the release

@prakhargupta1 prakhargupta1 merged commit 73c7d8f into mui:master Mar 4, 2024
12 checks passed
@prakhargupta1 prakhargupta1 deleted the list-datepicker-textfield branch March 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants