Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link WASM example to overview page and improve crud app #2726

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Link WASM example to overview page and improve crud app #2726

merged 12 commits into from
Oct 18, 2023

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Sep 26, 2023 •
edited
Loading

  • Linked WASM, data provider example to the Overview page
  • Added images to examples where it was missing
  • Delinked one of the custom data grid app

@prakhargupta1 prakhargupta1 changed the title Add WASM examples and improve crud app Add WASM example and improve crud app Sep 26, 2023
@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Sep 26, 2023
@prakhargupta1 prakhargupta1 changed the title Add WASM example and improve crud app Link WASM example to overview page and improve crud app Sep 26, 2023
@prakhargupta1 prakhargupta1 marked this pull request as ready for review September 27, 2023 08:53
@prakhargupta1
Copy link
Member Author

@bharatkashyap I have added Stripe app to the examples overview page, can you add the screenshot for it? I don't have the token.

@bharatkashyap
Copy link
Member

bharatkashyap commented Sep 27, 2023 •
edited
Loading

@bharatkashyap I have added Stripe app to the examples overview page, can you add the screenshot for it? I don't have the token.

I think we can add a README.md (similar to the other apps) to the Stripe example. test it out, polish the experience - and then add it to the examples page with a screenshot.

@prakhargupta1 prakhargupta1 requested review from a team and removed request for bharatkashyap October 17, 2023 11:50
apedroferreira
apedroferreira approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Just some minor text changes.

docs/src/modules/components/ExamplesGrid.js Outdated Show resolved Hide resolved
docs/src/modules/components/ExamplesGrid.js Outdated Show resolved Hide resolved
examples/datagrid-columns/README.md Outdated Show resolved Hide resolved
docs/src/modules/components/ExamplesGrid.js Show resolved Hide resolved
@prakhargupta1 prakhargupta1 merged commit 11d6d09 into mui:master Oct 18, 2023
11 checks passed
@prakhargupta1 prakhargupta1 deleted the examples branch November 1, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakhargupta1 @bharatkashyap @apedroferreira