Unify useDom, useDomLoader and useAppState #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Sounds good!
When the app state became more complex I ended up splitting these by different hooks, as I wasn't sure if we should have undo/redo logic eventually be separated from the DOM loading logic, for example. But it was all open to feedback / iteration.
This is less confusing and they were still not completely decoupled so if you feel like it's fine we can have it all together!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the three reducers into a single one
AppState. Having separateuseDom,useDomLoaderanduseAppState, each with a different subset of the same state feels a bit complicated. We can leave the selection to consumers of the state instead. I'm also trying to add more than just the dom in this app state and the nomenclature gets all messed up.