Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Hacker News client example #2170

Merged
merged 13 commits into from
Feb 21, 2024
Merged

[examples] Hacker News client example #2170

merged 13 commits into from
Feb 21, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 14, 2023 •
edited
Loading

Also adds a loading state to the list so it doesn't display as broken when the itemCount is still loading

@Janpot Janpot added the examples Relating to /examples label Feb 19, 2024
@Janpot Janpot marked this pull request as ready for review February 19, 2024 17:48
@Janpot Janpot requested a review from a team February 20, 2024 08:33
@Janpot Janpot changed the title WIP hn client example [examples] Hacker News client example Feb 20, 2024
prakhargupta1
prakhargupta1 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@prakhargupta1 prakhargupta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added the background color.

Screenshot 2024-02-21 at 10 51 14 AM

@Janpot Janpot merged commit 3db7a27 into mui:master Feb 21, 2024
11 checks passed
@Janpot Janpot deleted the hn-client branch February 21, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakhargupta1 prakhargupta1 prakhargupta1 approved these changes

Assignees
No one assigned
Labels
examples Relating to /examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @prakhargupta1