-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs-update #1829
Docs-update #1829
Conversation
Data binding and deployment updates. Things to fix: 1. Deployment icon 2. Verify deployment content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image seems a bit small.
Maybe we can have clearer "before" and "after" images so we can see how the binding changed things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the pic above this one, I have tried to show the binding and in the background there is the before image. Hopefully, it should be ok.
Deployment icon: maybe a rocket? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, Prakhar, just left some feedback and suggestions for copy changes!
All my opinion of course so feel free to disagree with any of them.
I've added a commit documenting |
That should be good! @apedroferreira Need your help in this. As per pages.ts it has something to do with mono repo docs. |
Just changing the icon? I'll try it. |
Yes |
My bad, looks like it's only possible to use icons from this file in those docs nav items https://github.com/mui/material-ui/blob/master/docs/src/modules/components/AppNavDrawerItem.js ( |
Picked a different icon for it to be merged.
Data binding and deployment updates. Things to fix: