Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated scope query #1827

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Mar 28, 2023

Closes #1745

Remove query from query scope.

Screenshot 2023-03-28 at 19 31 51

@apedroferreira apedroferreira added the core Infrastructure work going on behind the scenes label Mar 28, 2023
@apedroferreira apedroferreira self-assigned this Mar 28, 2023
@Janpot
Copy link
Member

Janpot commented Mar 29, 2023

My initial idea was to just hide it, but maybe it's time to remove it altogether. Are we using it anywhere in any of our applications?

@apedroferreira
Copy link
Member Author

apedroferreira commented Mar 29, 2023

My initial idea was to just hide it, but maybe it's time to remove it altogether. Are we using it anywhere in any of our applications?

Not sure, we can just hide it for some time and keep todo comments to remove it after some time has passed.

@apedroferreira apedroferreira enabled auto-merge (squash) March 29, 2023 16:32
@apedroferreira apedroferreira merged commit e1a71e7 into master Mar 29, 2023
@apedroferreira apedroferreira deleted the remove-deprecated-scope-query branch March 29, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query editor shows deprecated "query" in scope explorer
3 participants