Allow mutating page state in event handlers #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2023
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
| await result.value; | ||
|
|
||
| setPageBindings((existingBindings) => { | ||
| return Object.fromEntries( |
There was a problem hiding this comment.
Would our mapValues utility work here instead of Object.fromEntries(Object.entries ...?
apedroferreira
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1801
Closes #1569
Screen.Recording.2023-03-27.at.12.05.23.mov