-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try replacing tsc with tsup as build tool #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 23, 2023
Signed-off-by: Jan Potoms <[email protected]>
github-actions
bot
added
PR: out-of-date
The pull request has merge conflicts and can't be merged
and removed
PR: out-of-date
The pull request has merge conflicts and can't be merged
labels
Mar 24, 2023
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 28, 2023
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 28, 2023
Signed-off-by: Jan Potoms <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 29, 2023
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 30, 2023
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Mar 30, 2023
|
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 2, 2023
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into trouble using modules from
toolpad-app/src/**
in the cli because they depend on ESM-only modules (execa
,node-fetch@3
,fractional-indexing
,open-editor
). The current setup makes it impossible to use these modules in a commonjs context (e.g. like the new CLI).tsc
doesn't allow for transpiling dependencies. Proposing in this PR to move totsup
, which allows marking certain modules asnoExternal
. This can be used to bundle ESM only modules in the CLI.@mui/toolpad-components
Alternatives considered:
const { execa } = await import('execa')
everywhere: Not always applicable, the burden is on the module consumer, creates a split-brain between different modules, extra overheadmicrobundle
: slower, less batteries-included, less maintained, less popularbabel
: slow, less batteries-included@vercel/ncc
: seems to be mainly focused on creating single file, node.js only focussedhttps://npmtrends.com/microbundle-vs-tsdx-vs-tsup