Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bindings for properties that can be controlled in canvas #1696

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Disable bindings for properties that can be controlled in canvas #1696

merged 6 commits into from
Feb 23, 2023

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Feb 21, 2023 •
edited
Loading

Finishes fixing #1614.

Disable bindings for properties controllable in the canvas:

  • resizable height properties such as "height" in DataGrid
  • "columns" property in DataGrid

It was still possible to bind to these properties in the binding editor... but not after this PR!!! 😎

Screenshot 2023-02-21 at 20 06 12

@apedroferreira apedroferreira added the enhancement This is not a bug, nor a new feature label Feb 21, 2023
@apedroferreira apedroferreira self-assigned this Feb 21, 2023
@oliviertassinari oliviertassinari requested a deployment to disable-some-bindings - toolpad-db PR #1696 February 21, 2023 20:03 — with Render Abandoned
@apedroferreira apedroferreira requested review from Janpot and a team February 21, 2023 20:06
@apedroferreira apedroferreira marked this pull request as draft February 22, 2023 19:20
@apedroferreira apedroferreira removed request for a team and Janpot February 22, 2023 19:20
@oliviertassinari oliviertassinari temporarily deployed to disable-some-bindings - toolpad PR #1696 February 22, 2023 19:29 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to disable-some-bindings - toolpad PR #1696 February 22, 2023 19:30 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to disable-some-bindings - toolpad PR #1696 February 22, 2023 19:31 — with Render Destroyed
@apedroferreira apedroferreira marked this pull request as ready for review February 22, 2023 19:32
@apedroferreira apedroferreira merged commit 21607a2 into master Feb 23, 2023
@apedroferreira apedroferreira deleted the disable-some-bindings branch February 23, 2023 15:14
@apedroferreira apedroferreira mentioned this pull request Feb 23, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees

@apedroferreira apedroferreira

Labels
enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apedroferreira @bharatkashyap @oliviertassinari