Fix resizing after drag & drop UI changes #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
resizing-fixes - toolpad-db PR #1639
Render
Abandoned
apedroferreira
changed the title
oliviertassinari
temporarily deployed
to
resizing-fixes - toolpad PR #1639
Render
Destroyed
|
Just noticed there are console errors now too... will include the fix here. |
For what it's worth, I don't think we should support resizing from non-selected components. |
Yep I was just seeing if someone agreed on that, will make it only possible to resize the selected component. |
oliviertassinari
temporarily deployed
to
resizing-fixes - toolpad PR #1639
Render
Destroyed
oliviertassinari
temporarily deployed
to
resizing-fixes - toolpad PR #1639
Render
Destroyed
oliviertassinari
temporarily deployed
to
resizing-fixes - toolpad PR #1639
Render
Destroyed
oliviertassinari
requested a deployment
to
resizing-fixes - toolpad-db PR #1639
Render
Abandoned
oliviertassinari
temporarily deployed
to
resizing-fixes - toolpad PR #1639
Render
Destroyed
Janpot
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few issues with resizing after pushing the drag & drop UI changes, so here are some fixes/improvements:
Preview: https://toolpad-pr-1639.onrender.com