-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve behavior of image columns #1637
Conversation
Is there a way to have more control over the image size, or should there? Found a bug though, on the 2nd item the popover was looking really big to me and had a scroll bar: Screen.Recording.2023-02-07.at.17.54.01.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the bug I found, code seems good!
You can always create a custom component. I believe this is a more sensible default as it just behaves the way text behaves, i.e. just take the available space. The previous solution uses
I limited the size of the popover image. I also made sure cell alignment still works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can always create a custom component. I believe this is a more sensible default as it just behaves the way text behaves, i.e. just take the available space.
Sounds good, that's better now that we have custom component columns.
This looks good now!
Screen.Recording.2023-02-07.at.12.01.03.mov