-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fast edit option from preview #1603
Conversation
bytasv
commented
Jan 27, 2023
- Closes Faster way to edit a deployed/preview app #1536
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment but nothing major and might be a bit opinionated.
Also more opinionated design feedback:
- I feel like the shadow in the button and the blue color it's using don't match the Alert color too well? Could it be flatter and more consistent in color maybe?
- Also the font in the button seems a bit small.
- Another thing I might try, but not sure if it would look better, would be to place the button on the right side or center of the Alert bar. But it's just an idea!
It came up in my discussion with @gerdadesign what if we continue to show the top header bar in the preview mode? We can just replace Would there be any concerns with this approach? |
The preview header only shows up on preview version of the application. For the edit button this could be fine. But we were talking about adding a header bar that could house the hamburger button that opens the navigation menu when it's hidden on smaller screens. So the header we talked about during meeting would also need to show up on deployed applications. |
Yeah, so basically, there are 2 headers just like in this app. But as we discussed, let's skip the inner/app header for now. We'll only deploy an app with a sidebar. #813 We can separately deal with how to handle Toolpad apps on smaller screens. |
Only for preview, not in the deployed app. |
oh ok, then we can't use it to house the hamburger menu for the navigation drawer |
@prakhargupta1 @apedroferreira @Janpot I've replaced alert with app header: |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apedroferreira fixed the difference in font |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now. Thanks for the changes!