Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default template #1601

Merged
merged 3 commits into from
Jan 28, 2023
Merged

Change default template #1601

merged 3 commits into from
Jan 28, 2023

Conversation

bytasv
Copy link
Contributor

@bytasv bytasv commented Jan 27, 2023

CleanShot.2023-01-27.at.14.02.40.mp4

@bytasv bytasv requested a review from a team January 27, 2023 12:05
@bytasv bytasv self-assigned this Jan 27, 2023
@oliviertassinari oliviertassinari requested a deployment to default-tempalte - toolpad-db PR #1601 January 27, 2023 12:05 — with Render Abandoned
@bharatkashyap
Copy link
Member

We would also need to modify this test to use the hr template and potentially rename it to "can use HR template":
https://github.com/mui/mui-toolpad/blob/default-tempalte/test/integration/appTemplates.spec.ts#L8

@bytasv
Copy link
Contributor Author

bytasv commented Jan 27, 2023

Thanks, fixed the specs, this is ready for re-review

@oliviertassinari oliviertassinari temporarily deployed to default-tempalte - toolpad PR #1601 January 27, 2023 18:18 — with Render Destroyed
@bytasv bytasv merged commit 823b0ce into master Jan 28, 2023
@bytasv bytasv deleted the default-tempalte branch January 28, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees

@bytasv bytasv

Labels
feature: App Editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default isn't a blank page
3 participants
@bytasv @bharatkashyap @oliviertassinari