Make applyTransform runtime agnostic #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
remove-server-rt - toolpad-db PR #1585
Render
Abandoned
oliviertassinari
temporarily deployed
to
remove-server-rt - toolpad PR #1585
Render
Destroyed
bharatkashyap
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1521
dataSource/shared is intended for runtime, editor and server environment. It can't therefore import
quickjs. Luckily we have the recently createJsRuntimeabstraction that allows us to reuse higher level methods likeapplyTransformbetween different environments. Just by changing it to accept ajsRuntimeparameter