Fix webpack missing exports warnings #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
webpack-warnings - toolpad-db PR #1582
Render
Abandoned
Signed-off-by: Jan Potoms <[email protected]>
oliviertassinari
temporarily deployed
to
webpack-warnings - toolpad PR #1582
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into this trying to build a new runtime with a build step for #1521
There have been a bunch of missing exports warnings in webpack release build. This PR turns those warnings into errors, and removes the missing default imports. I'm leaving them as comments for documentation purposes. Even though in general we avoid committing commented out code. This file is intended to become obsolete anyway once a build step is introduced.