Only sign in to dockerhub if we intend to push images (#867)

Only log in dockerhub if we intend to push
mui · Aug 29, 2022 · 6572074 · 6572074
1 parent a39964e
commit 6572074
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -150,10 +150,6 @@ jobs:
     steps:
       - checkout
 
-      # login docker hub
-      - run: |
-          echo "$DOCKER_PASS" | docker login --username $DOCKER_USER --password-stdin
-
       # build the application image
       - run: |
           docker build \
@@ -186,6 +182,10 @@ jobs:
           condition:
             equal: [master, << pipeline.git.branch >>]
           steps:
+            # login docker hub
+            - run: |
+                echo "$DOCKER_PASS" | docker login --username $DOCKER_USER --password-stdin
+
             - run: |
                 docker push muicom/toolpad:$CIRCLE_SHA1
                 docker tag muicom/toolpad:$CIRCLE_SHA1 muicom/toolpad:alpha