feat: adapt to pre-processed styles #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
reviewed
Sep 18, 2024
| @@ -619,7 +619,11 @@ export class StyledProcessor extends BaseProcessor { | |||
| })), | |||
| ); | |||
| } | |||
| delete styleObj.variants; | |||
| if (styleObj.isProcessed) { | |||
There was a problem hiding this comment.
Should this check instead be for the presence of the key isProcessed instead of checking for true?
There was a problem hiding this comment.
This feels good to me, any reason for checking that way instead of this one?
There was a problem hiding this comment.
checking for key's presence makes sure that this object is coming from the new processor regardless of the value.
There was a problem hiding this comment.
The value can only be true, it makes more sense to check for true than for the key presence.
brijeshb42
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to pre-processed styles to match mui/material-ui#43412