[react] Fix css extraction for transformed styled tagged-template call #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Janpot I see some side-effects of Without 
With 
Ripple related fixes are working as expected. Just wanted to point this out since I was testing with the latest code. |
Janpot
changed the title
brijeshb42
force-pushed
the
fix/swc-tagged-template
branch
from
c54a7d6 to
ff99988
Compare
siriwatknp
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unpluginpackage.The main issue here is that
next.jsthroughswctranspiles files innode_moduleswhich also includes tagged template literals, converting them to a normalstyled()()with somewhat weird arguments.This transformation was not handled previously resulting in some missing css from the final output.