Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support null as a value for CSS object #229

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Support null as a value for CSS object #229

merged 2 commits into from
Sep 11, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 11, 2024

Part of mui/material-ui#43615

@siriwatknp siriwatknp added the enhancement This is not a bug, nor a new feature label Sep 11, 2024
Comment on lines +64 to +67
WebkitBoxShadow: theme.palette.mode === 'light' ? null : '0 0 0 100px #266798 inset',
WebkitTextFillColor: theme.palette.mode === 'light' ? null : '#fff',
caretColor: theme.palette.mode === 'light' ? null : '#fff',
borderRadius: 'inherit',
Copy link
Member Author

@siriwatknp siriwatknp Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this throws an error without the fix.

Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@siriwatknp siriwatknp merged commit f442f7a into master Sep 11, 2024
18 of 19 checks passed
@siriwatknp siriwatknp deleted the fix/error-n branch September 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants