fix: styled-engine new internals #220
Conversation
|
Duplicate of #219 |
| @@ -8,3 +8,4 @@ export { default as createUseThemeProps } from './createUseThemeProps'; | |||
| export { default as internal_createExtendSxProp } from './createExtendSxProp'; | |||
| export { default as useTheme } from './useTheme'; | |||
| export { default as globalCss } from './globalCss'; | |||
| export { default as internal_styledEngineMockup } from './styledEngineMockup'; | |||
There was a problem hiding this comment.
This should not be part of the public api (base module export) but can come from a path like @pigment-css/react/internal.
There was a problem hiding this comment.
I followed the convention for internal_createExtendSxProp right above. I'll move it to a new internal folder.
There was a problem hiding this comment.
You should also add this path to the exports in package.json
There was a problem hiding this comment.
I've tried it but it wasn't enough, not sure how the different (tsconfig|tsup).* files interact, any advice to setup the build properly?
There was a problem hiding this comment.
Nevermind, I think I got it.
| @@ -118,13 +120,7 @@ const pigmentOptions = { | |||
| ...context, | |||
| require: (id) => { | |||
| if (id === '@mui/styled-engine' || id === '@mui/styled-engine-sc') { | |||
| return { | |||
There was a problem hiding this comment.
This is not needed here. I'll clean this up separately since it's not a package.
There was a problem hiding this comment.
One last change needed is an entry it .gitignore and include internal in package.json's files key.
|
Should be good now. |
|
@brijeshb42 Can the netlify CI be ignored? And if so, could you merge this PR? I don't have write access to this repo. I'm also not sure how pigment-css releases work, when will this be released? If it's released by next week then I'll look into finalizing the PR on the core. |
|
I'll release it this week itself. Maybe by tomorrow. |
|
Ah I think I need this to be published to merge the core one, or the tests won't pass. Much appreciated if you can release it tomorrow. |
|
How would I go about setting that up? I see the http CSB package but iiuc that only works on CSB. I've checked by linking my local pigment repo to my local material repo. With the old branch if fails due to the internal API mismatch, and with the new branch if fails due to unrelated errors, so I'm assuming it's picking up the right thing. |
|
You can use the csb urls in the top level package.json's |
|
Published |
Update to match the changes in mui/material-ui#43412