Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Replace global JSX #183

Merged
merged 2 commits into from
Jul 19, 2024
Merged

[core] Replace global JSX #183

merged 2 commits into from
Jul 19, 2024

Conversation

DiegoAndai
Copy link
Member

Replace global JSX with React.JSX to prepare for upcoming @types/react version which removes global JSX.

This is required for mui/material-ui#42824.

@DiegoAndai DiegoAndai added the core Infrastructure work going on behind the scenes label Jul 19, 2024
@DiegoAndai DiegoAndai requested a review from brijeshb42 July 19, 2024 17:04
@DiegoAndai DiegoAndai self-assigned this Jul 19, 2024
brijeshb42
brijeshb42 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@DiegoAndai DiegoAndai merged commit ae72eea into mui:master Jul 19, 2024
11 of 12 checks passed
@DiegoAndai DiegoAndai deleted the replace-global-jsx branch July 19, 2024 18:12
@DiegoAndai DiegoAndai mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brijeshb42 brijeshb42 brijeshb42 approved these changes

Assignees

@DiegoAndai DiegoAndai

Labels
core Infrastructure work going on behind the scenes typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiegoAndai @brijeshb42 @oliviertassinari