Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I10n] Improve Finnish (fi-FI) locale on the data grid #6859

Merged
merged 1 commit into from
Nov 16, 2022
Merged

[I10n] Improve Finnish (fi-FI) locale on the data grid #6859

merged 1 commit into from
Nov 16, 2022

Conversation

RainoPikkarainen
Copy link
Contributor

columnMenuSortAsc and columnMenuSortDesc were inverted.

[I10n] Fix Finnish (fi-FI) locale translations
a172c56 
columnMenuSortAsc and columnMenuSortDesc were inverted.
@mui-bot
Copy link

mui-bot commented Nov 15, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6859--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 677.3 1,220.7 677.3 886.18 207.749
Sort 100k rows ms 639.5 1,397.1 1,397.1 1,080.06 269.04
Select 100k rows ms 267.2 361.7 297.5 302.68 32.789
Deselect 100k rows ms 150.5 374.3 233.2 254.2 73.876

Generated by 🚫 dangerJS against a172c56

@zannager zannager added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Nov 16, 2022
@flaviendelangle flaviendelangle changed the title [I10n] Fix Finnish (fi-FI) locale translations [I10n] Improve Finnish (fi-ImpFI) locale on the data grid Nov 16, 2022
@flaviendelangle flaviendelangle changed the title [I10n] Improve Finnish (fi-ImpFI) locale on the data grid [I10n] Improve Finnish (fi-FI) locale on the data grid Nov 16, 2022
@flaviendelangle flaviendelangle merged commit 827f0a3 into mui:next Nov 16, 2022
flaviendelangle added a commit to flaviendelangle/mui-x that referenced this pull request Nov 16, 2022
@flaviendelangle
[I10n] Improve Finnish (fi-FI) locale on the data grid (mui#6859)
e4e74e5
@flaviendelangle flaviendelangle mentioned this pull request Nov 16, 2022
Merged
@flaviendelangle
Copy link
Member

Thanks for your contribution !

flaviendelangle added a commit that referenced this pull request Nov 16, 2022
@flaviendelangle
[I10n] Improve Finnish (fi-FI) locale on the data grid (#6859) (#6872)
54b1175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RainoPikkarainen @mui-bot @flaviendelangle @zannager