[core] Add typing to the details argument #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
core
m4theushw
reviewed
Sep 3, 2021
| | <span class="prop-name">onCellDoubleClick</span> | <span class="prop-type">(params: GridCellParams, event: MuiEvent<React.MouseEvent>, details?: any) => void</span> | | Callback fired when a double click event comes from a cell element. | | ||
| | <span class="prop-name">onCellBlur</span> | <span class="prop-type">(params: GridCellParams, event: MuiEvent<React.FocusEvent>, details: GridCallbackDetails) => void</span> | | Callback fired when the active element leaves a cell. | | ||
| | <span class="prop-name">onCellClick</span> | <span class="prop-type">(params: GridCellParams, event: MuiEvent<React.MouseEvent>, details: GridCallbackDetails) => void</span> | | Callback fired when a click event comes from a cell element. | | ||
| | <span class="prop-name">onCellDoubleClick</span> | <span class="prop-type">(params: GridCellParams, event: MuiEvent<React.MouseEvent>, details: GridCallbackDetails) => void</span> | | Callback fired when a double click event comes from a cell element. | | ||
| | <span class="prop-name">onCellFocusOut</span> | <span class="prop-type">(params: GridCellParams, event?: MuiEvent<MouseEvent>) => void</span> | | Callback fired when a cell loses focus. | |
There was a problem hiding this comment.
The details argument is missing here.
There was a problem hiding this comment.
If #2465 is almost done, can we not add it manually on this PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detailsargument from the typing ofisCellEditable,isRowSelectable,getClassClassNameandgetRowClassName(it is not passed to those callbacks)detailsargument of the other callbacks