[core] Clean up grid column #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
m4theushw
reviewed
Aug 16, 2021
packages/grid/_modules_/grid/hooks/features/columns/useGridColumns.ts
Outdated
Show resolved
Hide resolved
m4theushw
approved these changes
Aug 19, 2021
oliviertassinari
force-pushed
the
column-cleanup
branch
from
5c76c89 to
375c5d6
Compare
|
I think we should stop using the term |
|
Happy to use a different terminology. I was using it coming from an backend perspective, for instance https://stackoverflow.com/questions/6991135/what-does-it-mean-to-hydrate-an-object (in my case it was from a python library not a Java one but it's the same concern I believe). Do you have an alternative in mind? |
|
When is this slated for release? |
|
Today or tomorrow |
|
This was merged into 4.0.0, and fixed the problem, huzzah! https://github.com/mui-org/material-ui-x/blob/next/CHANGELOG.md#400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to simplify the logic of this hook. It's mostly about renaming the variable to minimize the number of different terms we use. I have also skipped a few branches that seem to be unreachable.
I did this while I was looking into #2344
Closes #2333