[DataGrid] Fix prop-type warning with v5 #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
10 tasks
oliviertassinari
force-pushed
the
getDoc-v5
branch
from
eeebe11 to
5958c97
Compare
DanailH
approved these changes
Jul 28, 2021
flaviendelangle
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the warning visible in this reproduction: #2222 (comment).
https://codesandbox.io/s/blissful-herschel-xpm45?file=/src/Demo.tsx
It also improves cross-document support. Sebastian has figured out a smart way to remove the need for this
getDocprop in v5.