Skip to content

[DataGridPremium] Fix clipboard paste issue in portal#21931

Merged
MBilalShafi merged 3 commits into
mui:masterfrom
sibananda485:fix/21891-clipboard-paste-bug
Mar 31, 2026
Merged

[DataGridPremium] Fix clipboard paste issue in portal#21931
MBilalShafi merged 3 commits into
mui:masterfrom
sibananda485:fix/21891-clipboard-paste-bug

Conversation

@sibananda485
Copy link
Copy Markdown
Contributor

@sibananda485 sibananda485 commented Mar 30, 2026 •
edited by MBilalShafi
Loading

@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 30, 2026 •
edited
Loading

Deploy preview: https://deploy-preview-21931--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 🔺+7B(0.00%) 🔺+5B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against ff774fc

@mj12albert mj12albert added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. labels Mar 31, 2026
@mj12albert mj12albert requested a review from MBilalShafi March 31, 2026 07:10
@mj12albert
Copy link
Copy Markdown
Member

mj12albert commented Mar 31, 2026

I've added a test

@MBilalShafi MBilalShafi changed the title fix[data-grid]: fix clipboard paste issue in portal [DataGrid] Fix clipboard paste issue in portal Mar 31, 2026
@MBilalShafi MBilalShafi changed the title [DataGrid] Fix clipboard paste issue in portal [DataGridPremium] Fix clipboard paste issue in portal Mar 31, 2026
@MBilalShafi
Copy link
Copy Markdown
Member

MBilalShafi commented Mar 31, 2026 •
edited
Loading

Thank you @sibananda485 for the pull request. Since it touches the commercially licensed code, we need to agree the change is trivial or sign a CLA before proceeding to merge it.

IMPO, it is a trivial change, but I'd like to take your opinion around it. If you disagree, we can go ahead and sign a CLA.

@sibananda485
Copy link
Copy Markdown
Contributor Author

sibananda485 commented Mar 31, 2026

Thank you @sibananda485 for the pull request. Since it touches the commercially licensed code, we need to agree the change is trivial or sign a CLA before proceeding to merge it.

IMPO, it is a trivial change, but I'd like to take your opinion around it. If you disagree, we can go ahead and sign a CLA.

Thanks for the clarification!

Yes, I agree this is a trivial change. Happy to proceed without signing the CLA.

MBilalShafi
MBilalShafi approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for your contribution @sibananda485 🙏

@MBilalShafi MBilalShafi enabled auto-merge (squash) March 31, 2026 19:17
@MBilalShafi MBilalShafi added needs cherry-pick The PR should be cherry-picked to master after merge. v8.x feature: Clipboard Related to clipboard copy or paste functionalities labels Mar 31, 2026
@MBilalShafi MBilalShafi merged commit 6362c00 into mui:master Mar 31, 2026
30 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2026

Cherry-pick PRs will be created targeting branches: v8.x

github-actions Bot pushed a commit that referenced this pull request Mar 31, 2026
@sibananda485 @mj12albert
@MBilalShafi @web-flow
[DataGridPremium] Fix clipboard paste issue in portal (#21931)
a41b22d 
Co-authored-by: Albert Yu <albert@albertyu.co>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
@github-actions github-actions Bot mentioned this pull request Mar 31, 2026
Merged
@oliviertassinari oliviertassinari added the plan: Premium Impact at least one Premium user. label Apr 23, 2026
arminmeh pushed a commit to arminmeh/mui-x that referenced this pull request Apr 29, 2026
@sibananda485 @mj12albert
@MBilalShafi @arminmeh
[DataGridPremium] Fix clipboard paste issue in portal (mui#21931)
3e4d4e8 
Co-authored-by: Albert Yu <albert@albertyu.co>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees

No one assigned

Labels

feature: Clipboard Related to clipboard copy or paste functionalities needs cherry-pick The PR should be cherry-picked to master after merge. plan: Premium Impact at least one Premium user. scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected. v8.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keyboard shortcut causes unexpected dom behaviour if triggered in a Portal

5 participants

@sibananda485 @mui-bot @mj12albert @MBilalShafi @oliviertassinari