Skip to content

[charts] Fix zoom slider preview with discard filter mode#21883

Merged
JCQuintas merged 5 commits into
mui:masterfrom
JCQuintas:fix-preview-filter
Mar 30, 2026
Merged

[charts] Fix zoom slider preview with discard filter mode#21883
JCQuintas merged 5 commits into
mui:masterfrom
JCQuintas:fix-preview-filter

Conversation

@JCQuintas
Copy link
Copy Markdown
Member

Summary

  • Fix zoom slider preview to use unfiltered domains instead of normalized scales, ensuring the preview displays correctly when filterMode: 'discard' is used
  • Update ZoomSliderPreview demo to use filterMode: 'discard' and shared common props for consistency

@JCQuintas JCQuintas self-assigned this Mar 27, 2026
@JCQuintas JCQuintas added type: bug It doesn't behave as expected. plan: Pro Impact at least one Pro user. needs cherry-pick The PR should be cherry-picked to master after merge. scope: charts Changes related to the charts. v8.x labels Mar 27, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Mar 27, 2026

Deploy preview: https://deploy-preview-21883--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+32B(+0.01%) 🔺+11B(+0.01%)
@mui/x-charts-premium 🔺+32B(+0.01%) 🔺+15B(+0.01%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against b3e42c2

@JCQuintas JCQuintas enabled auto-merge (squash) March 27, 2026 12:25
} as const;

const commonProps = {
initialZoom: [{ axisId: 'x', start: 20, end: 80 }],
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added filterMode and changed initial zoom so that argos can pick any regression in this issue

@JCQuintas JCQuintas disabled auto-merge March 27, 2026 12:27
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 27, 2026

Merging this PR will not alter performance

✅ 14 untouched benchmarks


Comparing JCQuintas:fix-preview-filter (b3e42c2) with master (e1d56fa)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (db47fcb) during the generation of this report, so e1d56fa was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@JCQuintas JCQuintas merged commit b322127 into mui:master Mar 30, 2026
22 checks passed
@JCQuintas JCQuintas deleted the fix-preview-filter branch March 30, 2026 12:56
@github-actions
Copy link
Copy Markdown
Contributor

ghost commented Mar 30, 2026

Cherry-pick PRs will be created targeting branches: v8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs cherry-pick The PR should be cherry-picked to master after merge. plan: Pro Impact at least one Pro user. scope: charts Changes related to the charts. type: bug It doesn't behave as expected. v8.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants