Skip to content

[charts-pro] Handle edge case in export image #21190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardobelchior merged 3 commits into from
Feb 2, 2026
Merged

[charts-pro] Handle edge case in export image #21190

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1aed049
[charts-pro] Handle edge case in export image
bernardobelchior Jan 30, 2026
17d25cc
Suggest opening an issue
bernardobelchior Jan 30, 2026
061b03e
Reduce error message
bernardobelchior Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/x-charts-pro/src/internals/plugins/useChartProExport/exportImage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ export async function exportImage(
applyStyles(svg, previousStyles);
exportDoc.body.replaceChildren(elementClone);
exportDoc.body.style.margin = '0px';
/* Set display block through styles to ensure that CSS rules that target `body` don't accidentally target this
* iframe's body, which might cause the body to have no intrinsic width or height, leading to the canvas having a
* size of 0px, which causes the `toBlob` call to return null. */
exportDoc.body.style.display = 'block';
/* The body's parent has a width of 0, so we use fit-content to ensure that the body adjusts its width to the width
* of its children. */
exportDoc.body.style.width = 'fit-content';
Expand Down Expand Up @@ -83,6 +87,13 @@ export async function exportImage(
canvas.style.width = `${exportDocBodySize.width}px`;
canvas.style.height = `${exportDocBodySize.height}px`;

if (canvas.width === 0 || canvas.height === 0) {
doc.body.removeChild(iframe);
throw new Error(
`MUI X Charts: Cannot export an image with zero width or height. Width: ${canvas.width}px. Height: ${canvas.height}px.`,
);
}

try {
await drawDocument(iframe.contentDocument!, canvas, {
// Handle retina displays: https://github.com/cburgmer/rasterizeHTML.js/blob/262b3404d1c469ce4a7750a2976dec09b8ae2d6c/examples/retina.html#L71
Expand Down
Loading