Skip to content

Conversation

@github-actions
Copy link

Cherry-pick of #18345

Signed-off-by: Michel Engelen <[email protected]>
Co-authored-by: Jose C Quintas Jr <[email protected]>
Co-authored-by: Lukas Tyla <[email protected]>
@github-actions github-actions bot added cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Jun 19, 2025
@michelengelen
Copy link
Member

@LukasTy do you know why there are so many changes to the dependencies? Is it because we updated them in the last v8 release, but did not release v7 last week?

@LukasTy
Copy link
Member

LukasTy commented Jun 20, 2025

@LukasTy do you know why there are so many changes to the dependencies? Is it because we updated them in the last v8 release, but did not release v7 last week?

No, it's because we changed their definition to pnpm catalogs on master and you also added a dep in this PR.
We need manual adjustments to address it. 🙈

@mui-bot
Copy link

mui-bot commented Jun 20, 2025

Deploy preview: https://deploy-preview-18450--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 193a9b9

@LukasTy
Copy link
Member

LukasTy commented Jun 20, 2025

@michelengelen I've updated the dependency situation in this PR to match the original PR as closely as possible. 😉

@michelengelen michelengelen enabled auto-merge (squash) June 23, 2025 09:20
@LukasTy
Copy link
Member

LukasTy commented Jun 23, 2025

@michelengelen the test_package step will probably not pass, since the logic for it does not exist on this branch. 🤔
cc @Janpot Do you think it's worth backporting the bundle size reporting to the "LTS" branch?

@Janpot
Copy link
Member

Janpot commented Jun 23, 2025

cc @Janpot Do you think it's worth backporting the bundle size reporting to the "LTS" branch?

If you expect bundle size regressions. I'm not sure it'd be worth it, but it shouldn't be too hard to do (famous last words).

@LukasTy LukasTy disabled auto-merge June 23, 2025 10:38
@LukasTy LukasTy merged commit 5476012 into v7.x Jun 23, 2025
19 checks passed
@LukasTy LukasTy deleted the cherry-pick-18345-to-v7.x branch June 23, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants