[code-infra] Use catalog for reused dependencies
#18302
Conversation
LukasTy
added
type: enhancement
|
Deploy preview: https://deploy-preview-18302--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
| 'package.json needs to have a dependency on `@babel/runtime` when building with `@babel/plugin-transform-runtime`.', | ||
| ); | ||
| } else if (babelRuntimeVersion === 'catalog:') { | ||
| const listedBabelRuntime = execSync('pnpm list "@babel/runtime" --json'); |
There was a problem hiding this comment.
Babel was unhappy with the catalog: version. 🙈 😆
| ); | ||
| } else if (babelRuntimeVersion === 'catalog:') { | ||
| // resolve the version from the given package | ||
| const { stdout: listedBabelRuntime } = await exec('pnpm list "@babel/runtime" --json'); |
| checkMaterialVersion({ | ||
| packageJson, | ||
| materialPackageJson, | ||
| packageDirectory: 'packages/x-charts-pro', |
There was a problem hiding this comment.
Can't we use something like import.meta.url like we use in the vitest configs? Passing the current package path can be error prone, like if we use packages/x-data-grid on a charts package we will get the wrong results https://github.com/mui/mui-x/blob/master/vitest.config.mts#L5
There was a problem hiding this comment.
Good idea. 👍
Updated the solution.
Let me know what you think. 🙏
| // take only relevant part of the file path | ||
| // e.g. file:///Users/dev/mui/mui-x/packages/x-charts-pro/src/tests/materialVersion.test.tsx | ||
| // becomes packages/x-charts-pro | ||
| const workingDirectory = testFilePath.substring( |
There was a problem hiding this comment.
I've gone with a basic solution to avoid issues on Vite/browser (it didn't like node API).
3 participants
Use https://pnpm.io/catalogs to manage dependencies, which are used in at least 2 places.