Skip to content

[internal] Use a single browser server in CI #18230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 9, 2025
Merged

[internal] Use a single browser server in CI #18230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2c0d581
connect to ws
JCQuintas Jun 4, 2025
a045cd7
try using single browser instance for all tests
JCQuintas Jun 4, 2025
fdff35c
run async
JCQuintas Jun 4, 2025
39ab2eb
use static env
JCQuintas Jun 4, 2025
ad5eb59
use TZ
JCQuintas Jun 4, 2025
23cc011
run command in same step
JCQuintas Jun 4, 2025
df70b4d
move to script
JCQuintas Jun 4, 2025
c420e97
use node 23 for ts scripts
JCQuintas Jun 4, 2025
60ec5f5
file ext
JCQuintas Jun 4, 2025
f9a4431
mjs
JCQuintas Jun 4, 2025
81bcfc0
Merge branch 'master' into try-single-browser-server
JCQuintas Jun 4, 2025
bbe43a6
JCQuintas Jun 4, 2025
dc8d698
Merge branch 'master' into try-single-browser-server
JCQuintas Jun 4, 2025
53299db
prevent console warning
JCQuintas Jun 5, 2025
de0af9f
upgrade vite/vitest packages
JCQuintas Jun 5, 2025
f1f8d8b
Merge branch 'master' into try-single-browser-server
JCQuintas Jun 5, 2025
deae179
Merge commit 'edf1a431e274e43d2182a2c9726b56558619cdc4' into try-sing…
JCQuintas Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,21 +162,31 @@ jobs:
- install_js:
playwright: true
react-version: << parameters.react-version >>

- when:
condition:
not:
equal: ['stable', << parameters.react-version >>]
steps:
- run:
environment:
TZ: UTC
PLAYWRIGHT_SERVER_WS: 'ws://127.0.0.1:9050/mui-browser'
name: Test Browser
command: pnpm test:unit:browser
command: |
node ./scripts/playwrightLaunchServer.mjs & pnpm test:unit:browser
- when:
condition:
equal: ['stable', << parameters.react-version >>]
steps:
- run:
name: Test Browser + Coverage
command: pnpm test:unit:browser --coverage
environment:
TZ: UTC
PLAYWRIGHT_SERVER_WS: 'ws://127.0.0.1:9050/mui-browser'
command: |
node ./scripts/playwrightLaunchServer.mjs & pnpm test:unit:browser --coverage

- run:
name: Check coverage generated
command: |
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,9 @@
"@types/yargs": "^17.0.33",
"@typescript-eslint/eslint-plugin": "^8.33.0",
"@typescript-eslint/parser": "^8.33.0",
"@vitejs/plugin-react": "^4.5.0",
"@vitest/browser": "^3.2.0",
"@vitest/coverage-v8": "^3.2.0",
"@vitejs/plugin-react": "^4.5.1",
"@vitest/browser": "^3.2.2",
"@vitest/coverage-v8": "^3.2.2",
Comment on lines +116 to +118
Copy link
Member Author

@JCQuintas JCQuintas Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also upgrade packages across the board as they released 20min ago 🤷

"@vvago/vale": "^3.11.2",
"autoprefixer": "^10.4.21",
"axe-core": "4.10.3",
Expand Down Expand Up @@ -195,7 +195,7 @@
"unist-util-visit": "^5.0.0",
"util": "^0.12.5",
"vite": "^6.3.5",
"vitest": "3.2.0",
"vitest": "3.2.2",
"vitest-fail-on-console": "^0.7.1",
"webpack": "^5.99.9",
"webpack-bundle-analyzer": "^4.10.2",
Expand Down
7 changes: 7 additions & 0 deletions packages/x-charts-pro/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
Comment on lines 14 to +21
Copy link
Member

@LukasTy LukasTy Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid this warning
Screenshot 2025-06-05 at 12 11 07

Suggested change
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {
browser: 'chromium',
}),

Copy link
Member Author

@JCQuintas JCQuintas Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these happen on the grid tests only, so I changed there

},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-charts/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-data-grid-premium/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
16 changes: 12 additions & 4 deletions packages/x-data-grid-pro/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,18 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
launch: {
// Required for tests which use scrollbars.
ignoreDefaultArgs: ['--hide-scrollbars'],
},
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {
launch: {
// Required for tests which use scrollbars.
ignoreDefaultArgs: ['--hide-scrollbars'],
},
}),
},
],
},
Expand Down
16 changes: 12 additions & 4 deletions packages/x-data-grid/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,18 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
launch: {
// Required for tests which use scrollbars.
ignoreDefaultArgs: ['--hide-scrollbars'],
},
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {
launch: {
// Required for tests which use scrollbars.
ignoreDefaultArgs: ['--hide-scrollbars'],
},
}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-date-pickers-pro/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-date-pickers/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-license/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-scheduler/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-telemetry/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-tree-view-pro/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/x-tree-view/vitest.config.browser.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ export default mergeConfig(sharedConfig, {
instances: [
{
browser: 'chromium',
...(process.env.PLAYWRIGHT_SERVER_WS
? {
connect: {
wsEndpoint: process.env.PLAYWRIGHT_SERVER_WS,
},
}
: {}),
},
],
},
Expand Down
Loading