Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetry] Update dependencies, and optimize SSR handling #17008

Merged
merged 11 commits into from
Mar 24, 2025

Conversation

hasdfa
Copy link
Member

@hasdfa hasdfa commented Mar 17, 2025

Enhancements

  • Fixed version of @fingerprintjs/fingerprintjs to use v3 because of licensing
  • Use esm version for post-install script
  • Omit send data in SSR mode

Updated dependencies

@hasdfa hasdfa added dependencies Update of dependencies package: x-license Specific to @mui/x-license. enhancement This is not a bug, nor a new feature labels Mar 17, 2025
@hasdfa hasdfa self-assigned this Mar 17, 2025
Copy link

Multiple type labels found: dependencies, enhancement

Only one is allowed. Please remove the extra type labels to ensure the PR is categorized correctly.

3 similar comments
Copy link

Multiple type labels found: dependencies, enhancement

Only one is allowed. Please remove the extra type labels to ensure the PR is categorized correctly.

Copy link

Multiple type labels found: dependencies, enhancement

Only one is allowed. Please remove the extra type labels to ensure the PR is categorized correctly.

Copy link

Multiple type labels found: dependencies, enhancement

Only one is allowed. Please remove the extra type labels to ensure the PR is categorized correctly.

@mui-bot
Copy link

mui-bot commented Mar 17, 2025

Deploy preview: https://deploy-preview-17008--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e90d25c

@hasdfa hasdfa removed the dependencies Update of dependencies label Mar 17, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 18, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 23, 2025
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. 👍

Sidenote: Should we create a label for this package and add a separate entry in the changelog generation? 🤔
cc @michelengelen

IMHO, I think we could start with just a label, but keeping entries in the Core section.

P.S. A more detailed PR title wouldn't hurt. 😉

@LukasTy LukasTy changed the title [x-telemetry] Improvements [telemetry] Improvements Mar 24, 2025
@hasdfa hasdfa changed the title [telemetry] Improvements [telemetry] Improve request body size, update dependencies, and optimize SSR handling Mar 24, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2025
@hasdfa hasdfa merged commit 8127c75 into mui:master Mar 24, 2025
21 checks passed
@hasdfa hasdfa changed the title [telemetry] Improve request body size, update dependencies, and optimize SSR handling [telemetry] Update dependencies, and optimize SSR handling Mar 24, 2025
@hasdfa hasdfa deleted the x-telemetry/improvements branch March 24, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature package: x-license Specific to @mui/x-license.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants