[fields] Clean the useField hook (part 1)
#16944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding a type label to the PR! 👍 |
flaviendelangle
added
core
|
Deploy preview: https://deploy-preview-16944--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
useField-clean
branch
from
c470b05 to
bfc0bbd
Compare
flaviendelangle
force-pushed
the
useField-clean
branch
from
bfc0bbd to
4f8d3bb
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
flaviendelangle
added
maintenance
and removed
enhancement
michelengelen
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st part of the cleaning needed in order to create the new Base UI Field component.
Based on #14679 and #16060
No behavior change
In this PR
useField(that will simplify dropping the old DOM structure AND this is needed if we want to build a Base UI version)useFieldhookuseFieldfolder (manager,internalPropsWithDefaults,forwardedProps,stateResponseandcharacterEditingResponse). This make the data flow a lot easier to reason about for the upcoming changes.useTimeoutfor all the timeoutuseField.typesFollow up
useFieldV7TextFieldinto smaller hooks that can be used by the Base UI component. These hooks should not apply any logic that is Base UI-incompatible (for example when creating an event callback, it should not call the equivalent prop, because this will be handled later down the line in the Base UI codebase).