[DataGrid] Refactor: remove more material #16922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
|
Thanks for adding a type label to the PR! 👍 |
romgrk
commented
Mar 11, 2025
Comment on lines
-18
to
+20
| slotProps?: { button?: Partial<ButtonProps>; tooltip?: Partial<TooltipProps> }; | ||
| slotProps?: { | ||
| button?: Partial<GridSlotProps['baseButton']>; | ||
| tooltip?: Partial<GridSlotProps['baseTooltip']>; | ||
| }; |
There was a problem hiding this comment.
This has the same issue mentioned in other places, those components are now base components and not material components, so if a user tries to pass material-ui props, they'll be disappointed.
|
Deploy preview: https://deploy-preview-16922--material-ui-x.netlify.app/ |
romgrk
commented
Mar 12, 2025
packages/x-data-grid/src/components/toolbar/GridToolbarFilterButton.tsx
Outdated
Show resolved
Hide resolved
KenanYusuf
approved these changes
Mar 13, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Kenan Yusuf <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the design-system agnostic work.
This removes the remaining (non-style related) imports from material.