[DataGrid] Fix toggling preference panel from toolbar #16274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compare:
|
|
Deploy preview: https://deploy-preview-16274--material-ui-x.netlify.app/ |
cherniavskii
changed the title
cherniavskii
added
bug 🐛
cherniavskii
approved these changes
Jan 20, 2025
|
Cherry-pick PRs will be created targeting branches: v7.x |
A-s-h-o-k
pushed a commit
to A-s-h-o-k/mui-x
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cherniavskii, seems like I did break something still in #16257 – can't re-close panels from toolbar buttons due to clickaway being triggered first. Fixed it in this PR.
Fixes another issue as a side-effect – when closing preference panel while clicking on a data grid cell, the focus is correctly placed in the cell. Currently (in the public docs), the focus gets lost (briefly shows focus in the datagrid, and then it gets removed).