Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Divide the SeriesProvider to use in filtering #14026

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[charts] Divide the SeriesProvider to use in filtering #14026

merged 3 commits into from
Jul 30, 2024

Conversation

JCQuintas
Copy link
Member

Code mostly as cleanup for zoom filtering, as I will probably need to introduce SeriesProviderPro 😅

  • Moved from SeriesContextProvider.tsx to SeriesProvider/ folder.
  • Renamed SeriesContextProvider to SeriesProvider
    • In this case it is not a breaking change I believe, but should we look into following a pattern eg: XxxContext for the context, XxxProvider for the provider in v8?

@JCQuintas JCQuintas added enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! labels Jul 29, 2024
@JCQuintas JCQuintas self-assigned this Jul 29, 2024
@mui-bot
Copy link

mui-bot commented Jul 29, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14026--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against bed6d64

alexfauquette
alexfauquette approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we could have a standard for v8. Can you open an issue for tracking it?

@JCQuintas JCQuintas enabled auto-merge (squash) July 30, 2024 08:32
@JCQuintas JCQuintas disabled auto-merge July 30, 2024 11:44
@JCQuintas JCQuintas merged commit b84c080 into mui:master Jul 30, 2024
16 checks passed
@JCQuintas JCQuintas deleted the divide-series-provider branch July 30, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@JCQuintas JCQuintas

Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JCQuintas @mui-bot @alexfauquette