Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Playwright #13672

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bump Playwright #13672

wants to merge 5 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 30, 2024 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
@playwright/test (source) ^1.44.1 -> ^1.46.0 age adoption passing confidence devDependencies minor
mcr.microsoft.com/playwright v1.44.1-focal -> v1.46.0-focal age adoption passing confidence docker minor

Release Notes

microsoft/playwright (@​playwright/test)

v1.46.0

Compare Source

v1.45.3

Compare Source

v1.45.2

Compare Source

v1.45.1

Compare Source

v1.45.0

Compare Source

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Jun 30, 2024
@mui-bot
Copy link

mui-bot commented Jun 30, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13672--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4b887cd

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 1, 2024
@renovate renovate bot force-pushed the renovate/playwright branch 2 times, most recently from 12f8e4d to 392a1f0 Compare July 2, 2024 18:37
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 4, 2024
@LukasTy LukasTy self-assigned this Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 4, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 4, 2024
@JCQuintas
Copy link
Member

@LukasTy it seems this is not taking a picture of the print anymore but of the page

@LukasTy
Copy link
Member

LukasTy commented Jul 4, 2024

@LukasTy it seems this is not taking a picture of the print anymore but of the page

Good point. 🤔
Well, it's either a regression or we need to adjust somehow. 🙈
Maybe the Playwright already has the option to take a print snapshot. 🤔

Are you looking into it? Or shall I?

@JCQuintas
Copy link
Member

@LukasTy I can try looking into it, do you have any context on why we use ffmpeg there?

@LukasTy
Copy link
Member

LukasTy commented Jul 4, 2024 •
edited
Loading

I can try looking into it, do you have any context on why we use ffmpeg there?

@JCQuintas I'm currently checking something.
ffmpeg is used to capture the print dialog, because Playwright can only capture a screenshot of the original browser page/window.
Not sure if this has changed over time. 🤔

@LukasTy
Copy link
Member

LukasTy commented Jul 4, 2024 •
edited
Loading

@JCQuintas It looks like Playwright or the latest released chromium browser is broken.
The printer window doesn't open. 🙈

EDIT: It does open on Firefox.
I'll experiment with it.

LukasTy
LukasTy reviewed Jul 4, 2024
View reviewed changes
test/e2e/index.test.ts Outdated
// The test is flaky on webkit
if (browserType.name() === 'webkit') {
// The test is flaky on webkit and firefox
if (browserType.name() === 'webkit' || browserType.name() === 'firefox') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seemed too flaky on firefox, I don't think it's worth spending time on re-running it. 🙈

@LukasTy LukasTy added on hold There is a blocker, we need to wait external dependency Blocked by external dependency, we can’t do anything about it labels Jul 4, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 5, 2024

From my tests, the print window is properly opening on chromium in versions 1.44, 1.45 and next so it might be that something specifically related to our implementation is not working. I tried a very simplified version of our logic and it properly opens the print dialog.

Thanks for clarifying. 👍
I would still think that waiting for the next release with the chromium without the mentioned bug and maybe a stable release (the current one seems to be a beta release if I understand correctly) would be safest.
WDYT?
Or is there something that is pushing as to bump ASAP? 🤔

@JCQuintas
Copy link
Member

No, we can close this and wait for next version

@JCQuintas JCQuintas closed this Jul 5, 2024
@LukasTy LukasTy reopened this Jul 5, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 5, 2024

No, we can close this and wait for next version

I've reopened the PR as there are relevant changes that are great improvements. 🤔

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 5, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 31, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 8, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 19, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 8, 2024
@JCQuintas
Copy link
Member

@flaviendelangle the argos issue is on the version of playwright itself... the print popup is not opening anymore. I'm not sure if this is an issue on our setup or on their side, the code is technically correct afaik 🙃

The pickers e2e issues I have no idea

@flaviendelangle
Copy link
Member

@JCQuintas I have a problem, the version that we use for playwright is not compatible with Ubuntu 2024.04 so I can't run my e2e test locally anymore 😢

@LukasTy LukasTy mentioned this pull request Oct 14, 2024
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 16, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LukasTy LukasTy

Labels
dependencies Update of dependencies external dependency Blocked by external dependency, we can’t do anything about it on hold There is a blocker, we need to wait PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mui-bot @JCQuintas @LukasTy @flaviendelangle