[TreeView] Add label editing feature #13388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraleonte
added
new feature
|
Deploy preview: https://deploy-preview-13388--material-ui-x.netlify.app/ Updated pages: |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.tsx
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewItems/useTreeViewItems.tsx
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewLabel/useTreeViewLabel.itemPlugin.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
PR: out-of-date
noraleonte
commented
Jun 17, 2024
packages/x-tree-view/src/hooks/useTreeItem2Utils/useTreeItem2Utils.tsx
Outdated
Show resolved
Hide resolved
LukasTy
approved these changes
Aug 1, 2024
docs/data/tree-view/rich-tree-view/editing/CustomLabelInput.tsx
Outdated
Show resolved
Hide resolved
docs/data/tree-view/rich-tree-view/editing/CustomLabelInput.tsx
Outdated
Show resolved
Hide resolved
| import EditOutlinedIcon from '@mui/icons-material/EditOutlined'; | ||
| import CloseRoundedIcon from '@mui/icons-material/CloseRounded'; | ||
| import CheckIcon from '@mui/icons-material/Check'; | ||
| import { TreeItem2LabelInput } from '@mui/x-tree-view/TreeItem2/TreeItem2'; |
There was a problem hiding this comment.
Do you have any idea why ESLint didn't catch these? 🤔
| response.getItemRoot('1').focus(); | ||
| }); | ||
| fireEvent.doubleClick(response.getItemLabel('1')); | ||
| fireEvent.change(response.getItemLabelInput('1'), { target: { value: 'new value' } }); |
There was a problem hiding this comment.
Have you considered using the newly available userEvent on the response and the Keyboard API? 🤔
https://testing-library.com/docs/user-event/keyboard
packages/x-tree-view/src/internals/plugins/useTreeViewLabel/useTreeViewLabel.tsx
Outdated
Show resolved
Hide resolved
LukasTy
changed the title
docs/data/tree-view/rich-tree-view/editing/CustomLabelInput.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Nora <[email protected]>
LukasTy
reviewed
Aug 6, 2024
packages/x-tree-view/src/internals/plugins/useTreeViewLabel/useTreeViewLabel.ts
Outdated
Show resolved
Hide resolved
flaviendelangle
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
https://deploy-preview-13388--material-ui-x.netlify.app/x/react-tree-view/rich-tree-view/editing/
To do: