Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Stop publishing v6 under latest tag #13269

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

cherniavskii
Copy link
Member

To avoid having v6 packages being marked as latest in NPM.

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label May 27, 2024
@cherniavskii cherniavskii requested a review from a team May 27, 2024 16:41
@alexfauquette
Copy link
Member

I assume you want to merge this on v6.x not on master.

Should it be added to the notion guide about how to switch version?

@mui-bot
Copy link

mui-bot commented May 27, 2024

Deploy preview: https://deploy-preview-13269--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f85e836

@cherniavskii
Copy link
Member Author

Right, I got confused because it would've been master branch if it was the core repo 😅

This comment was marked as outdated.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 27, 2024
@cherniavskii cherniavskii changed the base branch from master to v6.x May 27, 2024 17:00
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 27, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! 👏
The change makes sense to me. 👍

@cherniavskii
Copy link
Member Author

Not sure why vale check hasn't started. I'll ignore it and merge anyway since vale is not relevant for this PR

@cherniavskii cherniavskii merged commit d649cbb into mui:v6.x May 28, 2024
16 checks passed
@cherniavskii cherniavskii deleted the npm-tag branch May 28, 2024 14:13
@LukasTy
Copy link
Member

LukasTy commented May 28, 2024

Not sure why vale check hasn't started. I'll ignore it and merge anyway since vale is not relevant for this PR

It happens from time to time on both master as well as v6.x as far as I've seen. 🙈 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants