Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix missing context display names #12124

Merged
merged 4 commits into from
Feb 20, 2024
Merged

[core] Fix missing context display names #12124

merged 4 commits into from
Feb 20, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 18, 2024 •
edited
Loading

mui/material-ui#18468 is still relevant today. Make this change to restore the previous DX we had.

Before
SCR-20240218-qmlr

After
SCR-20240218-qmdz

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes dx Related to developers' experience labels Feb 18, 2024
@oliviertassinari oliviertassinari mentioned this pull request Feb 18, 2024
Merged
@mui-bot
Copy link

mui-bot commented Feb 18, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12124--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ab133f8

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

alexfauquette
alexfauquette approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we harmonize the use of the Mui prefix?

We have MuiPickersAdapterContext and now MuiLicenseInfoContext and others are not prefixed with Mui

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 20, 2024 •
edited
Loading

Should we harmonize the use of the Mui prefix?

@alexfauquette I think that we can remove Mui in MuiPickersAdapterContext. We usually don't prefix any exported module with Mui. cc @LukasTy.

For MuiLicenseInfoContext, it's a private API. It's meant to match with window.__MUI_LICENSE_INFO__, I wouldn't change this.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 20, 2024
@oliviertassinari oliviertassinari enabled auto-merge (squash) February 20, 2024 23:16
@oliviertassinari oliviertassinari merged commit f20a8fc into mui:next Feb 20, 2024
15 checks passed
@oliviertassinari oliviertassinari deleted the context-display-name branch February 20, 2024 23:49
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@oliviertassinari @thomasmoon
[core] Fix missing context display names (mui#12124)
7b519fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes dx Related to developers' experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @alexfauquette