Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Add method to check the existence of optional dependencies #13777

Closed
noraleonte opened this issue Jul 9, 2024 · 1 comment · Fixed by #13788
Closed

[TreeView] Add method to check the existence of optional dependencies #13777

noraleonte opened this issue Jul 9, 2024 · 1 comment · Fixed by #13788
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!

Comments

@noraleonte
Copy link
Contributor

noraleonte commented Jul 9, 2024 •
edited by github-actions bot
Loading

Since #13523 we support optional dependencies for plugins. When using methods from optional dependencies, we need to check if those methods actually exist. We should consider adding a cleaner way to check if the deps exist.
i.e. instance.hasPlugin(useTreeViewEditLabel)

Originally posted in #13388 (comment)

Search keywords:
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 9, 2024
@noraleonte noraleonte added component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 9, 2024
@noraleonte noraleonte mentioned this issue Jul 9, 2024
Merged
6 tasks
@flaviendelangle flaviendelangle self-assigned this Jul 10, 2024
@flaviendelangle flaviendelangle mentioned this issue Jul 10, 2024
Merged
@github-actions GitHub Actions
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@noraleonte: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@michelengelen michelengelen changed the title [Tree View] Add method to check the existance of optional dependencies [TreeView] Add method to check the existence of optional dependencies Jul 15, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TreeView] Add utility function to check if an optional plugin is present flaviendelangle/mui-x
2 participants
@flaviendelangle @noraleonte